Martin Sivák has submitted this change and it was merged. Change subject: don't use direct io on lv based devices ......................................................................
don't use direct io on lv based devices In python the O_DIRECT flag doesn't work properly, because it needs the buffer alligned to 512B to read into and in python it's not possible to control the size so the attempt to read from file using O_DIRECT fails with an os exception. It's also doubtful if it ever worked as intended because the code used direct_io only to read, but not write. Change-Id: Ie5264e1757e43f22e860af3869495ebab15e0d85 Signed-off-by: Jiri Moskovcak <[email protected]> --- M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/env/constants.py.in M ovirt_hosted_engine_ha/lib/storage_backends.py 3 files changed, 10 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/27971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5264e1757e43f22e860af3869495ebab15e0d85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
