Omer Frenkel has posted comments on this change. Change subject: core: don't check for vm.getVdsGroupId on import vm ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27998/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 177: @Override Line 178: protected boolean canDoAction() { Line 179: Map<Guid, StorageDomain> domainsMap = new HashMap<Guid, StorageDomain>(); Line 180: Line 181: if (getVdsGroup() == null) { > does it mean that getVm().getVdsGroupId() is always null? we use it in seve its null until it is set in execute, but i did a little cleanup not to use it anyway Line 182: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CLUSTER_CAN_NOT_BE_EMPTY); Line 183: return false; Line 184: } Line 185: -- To view, visit http://gerrit.ovirt.org/27998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21610313a85fa52a14b1ddf15b20e2ca73944e06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
