Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introduce auth_scheme context key ......................................................................
Patch Set 4: (2 comments) great! but please use shorter lines within paragraph so it wraps correctly when reviewing, it hard to review javadoc anyway... also keep 1st sentence short when describe (the first dot). thanks! and sorry for these http://gerrit.ovirt.org/#/c/28011/4/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java: Line 23: public static final ExtKey CAPABILITIES = new ExtKey("AAA_AUTHN_CAPABILITIES", Long.class, "9d16bee3-10fd-46f2-83f9-3d3c54cf258d"); Line 24: Line 25: /** Line 26: * A list of authentication scheme elements a client will receive with an HTTP 401 (unauthorized) response Line 27: * message to enable client negotiation. so you had this longer? it was fine... just to make sorter lines :) Line 28: */ Line 29: public static final ExtKey HTTP_AUTHENTICATION_SCHEME = new ExtKey("AAA_HTTP_AUTHENTICATION_SCHEME", List/*<String>*/.class, "c0a5c8b4-870b-436e-aeb9-1cd5307b2058"); Line 30: } Line 31: Line 96: * Negotiate authentication. Line 97: * Line 98: * Inspect HttpServletRequest and optionally interact with remote using HttpServletResponse. Line 99: * {@link InvokeKeys#RESULT} must be set with negotiation result. The Line 100: * {@link ContextKeys#HTTP_AUTHENTICATION_SCHEME} value is sent when HTTP 401 response is sent, to enable client please split this line... keep at most of 70 chars, thanks! Line 101: * negotiation. Line 102: * Line 103: * <p> Line 104: * Input: -- To view, visit http://gerrit.ovirt.org/28011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1141209b53de9f891e8051d9d18d74ed8b49614 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
