Gilad Chaplik has posted comments on this change. Change subject: webadmin: Add description and data center columns under cluster policy tab ......................................................................
Patch Set 1: (2 comments) minor issue. http://gerrit.ovirt.org/#/c/27989/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3340: Line 3341: @DefaultStringValue("Cluster Description") Line 3342: String clusterPolicyClusterDescription(); Line 3343: Line 3344: @DefaultStringValue("Cluster Datacenter") /s/r Datacenter/r's Data Center/ or /s/Cluster Datacenter/Data Center/ Line 3345: String clusterPolicyClusterDatacenter(); Line 3346: Line 3347: @DefaultStringValue("Properties") Line 3348: String clusterPolicyPropertiesLabel(); http://gerrit.ovirt.org/#/c/27989/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyView.java: Line 172: Line 173: private void initClustersTable(ApplicationConstants constants) { Line 174: clusterTable = new SimpleActionTable<VDSGroup>(clusterPolicyClusterModelProvider, Line 175: getTableHeaderlessResources(), getTableResources(), eventBus, clientStorage); Line 176: clusterTable.enableColumnResizing(); +1 Line 177: Line 178: TextColumnWithTooltip<VDSGroup> clusterColumn = new TextColumnWithTooltip<VDSGroup>() { Line 179: @Override Line 180: public String getValue(VDSGroup object) { -- To view, visit http://gerrit.ovirt.org/27989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf1ff6001d632ced66ce4de689bca3a46a8e1a37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
