Shubhendu Tripathi has posted comments on this change. Change subject: restapi: API support to query gluster volume profile info ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/28010/2//COMMIT_MSG Commit Message: Line 36: </brick_profileDetail> Line 37: ... Line 38: <nfs_profileDetails> Line 39: <nfs_profileDetail> Line 40: <nfsServerIp>server-ip</nfsServerIp> Unwanted noise because of tabs. Line 41: <profile_detail> ... </profile_detail> Line 42: </nfs_profileDetail> Line 43: </nfs_profileDetails> Line 44: </volume_profileDetails> http://gerrit.ovirt.org/#/c/28010/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java: Line 184: } Line 185: } Line 186: Line 187: private Boolean isNfsStatistics() { Line 188: if (getUriInfo()!=null && QueryHelper.hasMatrixParam(getUriInfo(), NFS_CONSTRAINT_PARAMETER)) { space between values and operator ? Line 189: HashMap<String, String> matrixConstraints = QueryHelper.getMatrixConstraints(getUriInfo(), NFS_CONSTRAINT_PARAMETER); Line 190: String maxString = matrixConstraints.get(NFS_CONSTRAINT_PARAMETER); Line 191: return Boolean.valueOf(maxString); Line 192: } else { http://gerrit.ovirt.org/#/c/28010/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/StatisticResourceUtils.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/StatisticResourceUtils.java: Line 29: statistic.getValues().getValues().add(new Value()); Line 30: return statistic; Line 31: } Line 32: Line 33: public static String asId(String name) { Does this method really belong to this class? I feel it should be in some common utils class. Line 34: return UUID.nameUUIDFromBytes(name.getBytes()).toString(); Line 35: } Line 36: Line 37: public static Statistic setDatum(Statistic statistic, BigDecimal datum) { -- To view, visit http://gerrit.ovirt.org/28010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff04cc30f01a7fbe9d6e48b8498d405d05c41c25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
