Frank Kobzik has posted comments on this change.

Change subject: frontend: RNG device sources reporting
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/22259/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java:

Line 2162:     }
Line 2163: 
Line 2164:     private void setRngDeviceToParams(UnitVmModel model, 
VmManagementParametersBase parameters) {
Line 2165:         parameters.setUpdateRngDevice(true);
Line 2166:         boolean rngEnabledAndValid = (Boolean) 
model.getIsRngEnabled().getEntity() && 
!model.getSelectedCluster().getRequiredRngSources().isEmpty();
> I don't think it is done - I don't see any changes in in this three classes
Done :)
Line 2167:         parameters.setRngDevice(rngEnabledAndValid
Line 2168:                 ? model.generateRngDevice()
Line 2169:                 : null);
Line 2170:     }


-- 
To view, visit http://gerrit.ovirt.org/22259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd065835d18575b686ee805b032662205b31c966
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to