Sandro Bonazzola has posted comments on this change. Change subject: ovirt-host-deploy:Fix: Password to be asked before engine log collection. ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28065/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-05-23 17:53:50 +0530 Line 4: Commit: ndarshan <[email protected]> Line 5: CommitDate: 2014-05-23 18:23:57 +0530 Line 6: Line 7: ovirt-host-deploy:Fix: Password to be asked before engine log collection. this is not ovirt-host-deploy I think that you can just say "Ask password before engine-log-collection" Line 8: Line 9: The Rest-Api password to be asked before collecting the engine log Line 10: whenever needed. Currently the password is asked after collecting Line 11: engine and postgres data. http://gerrit.ovirt.org/#/c/28065/1/src/__main__.py File src/__main__.py: Line 1674: hypervisor data will be collected.") Line 1675: else: Line 1676: collector.get_engine_data() Line 1677: collector.get_postgres_data() Line 1678: logging.info("Skipping hypervisor collection...") Maybe better something like: hosts_present = None try: if conf.get("no_hypervisor"): logging.info("Skipping hypervisor collection...") else: hosts_present = collector.set_hosts() except Exception as e: #allow to collect engine data also if engine is down .... collector.get_engine_data() collector.get_postgres_data() if hosts_present: collector.get_hypervisor_data() else: #say why not collected .... Line 1679: stdout = collector.archive() Line 1680: logging.info(stdout) Line 1681: elif conf.command == "list": Line 1682: if collector.set_hosts(): -- To view, visit http://gerrit.ovirt.org/28065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e49f3196f5dc5076fe784d7819160dba24e0184 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
