Moti Asayag has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java: Line 14: /** Line 15: * Base abstract class for QoS objects Line 16: * Line 17: */ Line 18: public abstract class BaseQos extends IVdcQueryable implements BusinessEntity<Guid>, Serializable { > will consider.. Under the common project, there are 38 classes which comply to *Base, vs 2 that comply to Base*: Project homogeneity is important and it adheres the de-facto standards. Can't find a reason to violate it, and if there is one, we should discuss it on list (i.e. embracing a different set of coding conventions) masayag@localhost: [ovirt] ~/work/ovirt-engine/backend/manager/modules/common (master)$ find . -name "Base*.java" | wc -l 2 masayag@localhost: [ovirt] ~/work/ovirt-engine/backend/manager/modules/common (master)$ find . -name "*Base.java" | wc -l 38 Line 19: private static final long serialVersionUID = 1122772549710787678L; Line 20: private Guid id = Guid.Empty; Line 21: private QosType qoSType; Line 22: Line 31: private BaseQos() { Line 32: } Line 33: Line 34: public BaseQos(QosType qoSType) { Line 35: this(); why there is a need to call this() ? Line 36: this.qoSType = qoSType; Line 37: } Line 38: /** Line 39: * @return object's type http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1092: ACTION_TYPE_FAILED_GLUSTER_VOLUME_CANNOT_STOP_REBALANCE_IN_PROGRESS= Cannot ${action} ${type}. Rebalance is running on the volume ${volumeName} in cluster ${vdsGroup}. Line 1093: ACTION_TYPE_FAILED_GLUSTER_OPERATION_INPROGRESS=Cannot ${action} ${type}. Gluster operation is in progress in cluster. Please try again. Line 1094: ACTION_TYPE_FAILED_TAG_ID_REQUIRED=Cannot ${action} ${type}. Tag ID is required. Line 1095: Line 1096: ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range. > will open a bug once the patch is merged. why not as part of this patch ? Line 1097: Line 1098: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action} ${type}. All three values are needed in order to define QoS on each network directions. Line 1099: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES=Cannot ${action} ${type}. Negative values are not allowed. Line 1100: ACTION_TYPE_FAILED_NETWORK_QOS_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range. -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
