Frank Kobzik has posted comments on this change. Change subject: frontend: Control virtio rng device ......................................................................
Patch Set 34: (5 comments) http://gerrit.ovirt.org/#/c/18497/34/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java: Line 463: param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity()); Line 464: param.setVirtioScsiEnabled(model.getIsVirtioScsiEnabled().getEntity()); Line 465: Line 466: param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 467: param.setRngDevice(model.getIsRngEnabled().getEntity() ? model.generateRngDevice() : null); > missing the param.setUpdateRngDevice(true); nope :) there is no such thing in pools since we don't need 'update' operation on pools and this flag is used only for update operation. Line 468: Line 469: param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 470: if (model.getQuota().getSelectedItem() != null) { Line 471: vm.setQuotaId(model.getQuota().getSelectedItem().getId()); http://gerrit.ovirt.org/#/c/18497/34/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java: Line 1165: confirmModel.setHelpTag(HelpTag.edit_next_run_configuration); Line 1166: confirmModel.setHashName("edit_next_run_configuration"); //$NON-NLS-1$ Line 1167: confirmModel.setCpuPluggable(selectedItem.getCpuPerSocket() == gettempVm().getCpuPerSocket() && Line 1168: selectedItem.getNumOfSockets() != gettempVm().getNumOfSockets()); Line 1169: // VmManagementParametersBase param = new VmManagementParametersBase(vm); > please remove sorry, these blocks were created when rebasing and I removed them only in the follow up. now it's fixed. Line 1170: // param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 1171: // param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity()); Line 1172: // setRngDeviceToParams(model, param); Line 1173: //// todo Line 1185: updateExistingVm(userPortalListModel, false); Line 1186: } Line 1187: } Line 1188: })); Line 1189: // todo > please remove Done Line 1190: // VmManagementParametersBase param = new VmManagementParametersBase(vm); Line 1191: // param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 1192: // param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity()); Line 1193: // setRngDeviceToParams(model, param); Line 1214: public void executed(FrontendActionAsyncResult result) { Line 1215: VmManagementParametersBase param = new VmManagementParametersBase(gettempVm()); Line 1216: param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 1217: param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity()); Line 1218: param.setApplyChangesLater(applyCpuChangesLater); > missing the setup of the rng thanks for this catch. Line 1219: Line 1220: Frontend.getInstance().runAction(VdcActionType.UpdateVm, param, new UnitVmModelNetworkAsyncCallback(model, defaultNetworkCreatingManager, gettempVm().getId()), this); Line 1221: } Line 1222: }, this); Line 1226: VmManagementParametersBase param = new VmManagementParametersBase(gettempVm()); Line 1227: param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity()); Line 1228: param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity()); Line 1229: param.setApplyChangesLater(applyCpuChangesLater); Line 1230: > missing the setup of the rng Done Line 1231: Frontend.getInstance().runAction(VdcActionType.UpdateVm, param, new UnitVmModelNetworkAsyncCallback(model, defaultNetworkCreatingManager, gettempVm().getId()), this); Line 1232: } Line 1233: } Line 1234: -- To view, visit http://gerrit.ovirt.org/18497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffbc48062f25d90795bc360362f42cd1042fb888 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
