Moti Asayag has posted comments on this change. Change subject: engine: Sending to the host oVirt-level default MTU ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/28098/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java: Line 63: if (network.getMtu() == 0) { Line 64: opts.put("mtu", Config.<Integer> getValue(ConfigValues.DefaultMTU).toString()); Line 65: } else { Line 66: opts.put("mtu", String.valueOf(network.getMtu())); Line 67: } > i just finished reading the same code three times... A refactor patch that handles the class completely, not just this specific attribute will follow. Line 68: Line 69: opts.put("bridged", Boolean.toString(network.isVmNetwork())); Line 70: if (network.isVmNetwork()) { Line 71: opts.put(VdsProperties.STP, network.getStp() ? "yes" : "no"); -- To view, visit http://gerrit.ovirt.org/28098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice358e3f4c10b08b9ddaed3b965d26e62cdb558a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
