Daniel Erez has posted comments on this change. Change subject: core: Initialze images for unregistered VM/Template ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/28163/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 60: String.format("$domainId %1$s", getParameters().getStorageDomainId()), Line 61: String.format("$domainType %1$s", getStorageDomain().getStorageDomainType())); Line 62: } Line 63: } Line 64: List<DiskImage> disks = new ArrayList(getVmTemplate().getDiskTemplateMap().values()); can be changed to ArrayList to avoid casting in setImages Line 65: setImagesWithStoragePoolId(getStorageDomain().getStoragePoolId(), disks); Line 66: getParameters().setImages(disks); Line 67: getVmTemplate().setImages((ArrayList)disks); Line 68: return super.canDoAction(); -- To view, visit http://gerrit.ovirt.org/28163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb9c68c2b28cceb1800ed21ecb9d9d24a4a05cac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
