Amador Pahim has posted comments on this change.

Change subject: [userportal-basic-gtk] First commit.
......................................................................


Patch Set 1:

1. The ca file is hard-coded as '/ovirt-engine/ca.crt', you cannot now that 
unless you look at the code - its best to add that to the login dialog or at 
least note that in the README file


Isn't it the default location on engine side? I'm adding it to readme and a 
message to status bar whenever the client cannot download it. 


2. I cannot login with no ca_file (ie not secure environment).


Could you detail this item? In userportalgtk.py, line 59 I have:

 59     self._ca_file = None 

It is intended to assure connection to not secure environment. Works for me.

-- 
To view, visit http://gerrit.ovirt.org/28142
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90ae1b0f7f734532ea6eb1cd97ab07fed25d55e1
Gerrit-PatchSet: 1
Gerrit-Project: samples-portals
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to