Simone Tiraboschi has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 18: (25 comments) http://gerrit.ovirt.org/#/c/27647/18/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 338 Line 339 Line 340 Line 341 Line 342 > these belongs to engine no? Done Line 353 Line 354 Line 355 Line 356 Line 357 > these belongs to engine no? Done Line 367 Line 368 Line 369 Line 370 Line 371 > these belongs to engine no? This indeed it's not used anymore in the engine plugin Line 439 Line 440 Line 441 Line 442 Line 443 > these belongs to engine-common no? Done Line 443 Line 444 Line 445 Line 446 Line 447 > these belongs to engine no? Done Line 452 Line 453 Line 454 Line 455 Line 456 > these belongs to engine no? Done Line 466 Line 467 Line 468 Line 469 Line 470 > these belongs to engine no? Done Line 468 Line 469 Line 470 Line 471 Line 472 > these belongs to engine no? Done Line 519 Line 520 Line 521 Line 522 Line 523 > not sure but looks to me that these system are of engine-common, not that i not sure, keep there now Line 520 Line 521 Line 522 Line 523 Line 524 > these belongs to engine no? Done Line 561 Line 562 Line 563 Line 564 Line 565 > engine-common Done Line 563 Line 564 Line 565 Line 566 Line 567 > engine-common engine, done Line 578 Line 579 Line 580 Line 581 Line 582 > engine Done Line 581 Line 582 Line 583 Line 584 Line 585 > engine Done Line 584 Line 585 Line 586 Line 587 Line 588 > engine ^^^^ Done Line 597 Line 598 Line 599 Line 600 Line 601 > engine Done Line 777 Line 778 Line 779 Line 780 Line 781 > engine-common Done Line 787 Line 788 Line 789 Line 790 Line 791 > engine-common, not that important, but we should somehow do this per compon engine, done Line 803 Line 804 Line 805 Line 806 Line 807 > engine Done Line 818 Line 819 Line 820 Line 821 Line 822 > engine Done Line 826 Line 827 Line 828 Line 829 Line 830 > engine Done Line 859 Line 860 Line 861 Line 862 Line 863 > go with engine Done Line 939 Line 940 Line 941 Line 942 Line 943 > all the above are of engine Done Line 1082 Line 1083 Line 1084 Line 1085 Line 1086 > not sure if remove and rename should not be in separate files, but defer th Deferred Line 1161 Line 1162 Line 1163 Line 1164 Line 1165 > engine + missing @util.export and @util.codegen Done -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
