Eli Mesika has posted comments on this change. Change subject: core: Add ExternalVariable entity ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27934/2/packaging/dbscripts/external_variable_sp.sql File packaging/dbscripts/external_variable_sp.sql: Line 2: -- Table external_variable Line 3: -- Line 4: Line 5: -- UpsertExternalVariable is used in fence_kdump listener Line 6: CREATE OR REPLACE FUNCTION UpsertExternalVariable( > I expect the table is used to share data between engine and external servic OK , less important , lets leave that as is Line 7: v_var_name VARCHAR(50), Line 8: v_var_value VARCHAR(255), Line 9: v_updated TIMESTAMP WITH TIME ZONE) Line 10: RETURNS VOID Line 5: -- UpsertExternalVariable is used in fence_kdump listener Line 6: CREATE OR REPLACE FUNCTION UpsertExternalVariable( Line 7: v_var_name VARCHAR(50), Line 8: v_var_value VARCHAR(255), Line 9: v_updated TIMESTAMP WITH TIME ZONE) > Do you think, that we will never need to pass predefined timestamp (I mean As far as I see all those _update* column are done in the DB context , so I think its is right to use the same I trust the admin to have the engine & DB time aligned Line 10: RETURNS VOID Line 11: AS $procedure$ Line 12: DECLARE Line 13: db_updated TIMESTAMP WITH TIME ZONE; http://gerrit.ovirt.org/#/c/27934/2/packaging/dbscripts/upgrade/03_05_0490_add_external_variable.sql File packaging/dbscripts/upgrade/03_05_0490_add_external_variable.sql: Line 2: -- Table is used to exchange data with external systems Line 3: -- Line 4: CREATE TABLE external_variable ( Line 5: var_name VARCHAR(50) NOT NULL, Line 6: var_value VARCHAR(255), > Do you mean to change it to VARCHAR(4000) same as option_value in vdc_optio Yes Line 7: updated TIMESTAMP WITH TIME ZONE NOT NULL, Line 8: CONSTRAINT pk_external_variable PRIMARY KEY(var_name) Line 9: ) WITH OIDS; Line 10: -- To view, visit http://gerrit.ovirt.org/27934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61ffd646c102c01c34478309d072f74a8f7d7edf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
