Allon Mureinik has posted comments on this change. Change subject: core: avoid broken status on snapshot removal ......................................................................
Patch Set 9: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27611/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java: Line 198: ImagesContainterParametersBase imagesParams = (parameters instanceof ImagesContainterParametersBase ? Line 199: (ImagesContainterParametersBase) parameters : null); Line 200: Line 201: if (imagesParams == null) { Line 202: // Shouldn't happen as for now ImagesParameters list contains only If it shouldn't happen, why check it? Line 203: // instances of ImagesContainterParametersBase objects. Line 204: continue; Line 205: } Line 206: -- To view, visit http://gerrit.ovirt.org/27611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a15034185ef30f53fbeaa46440cd92954d39eee Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
