Maor Lipchuk has posted comments on this change. Change subject: core: adding option to not connect host to inactive domains servers ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/27522/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-05-07 16:26:17 +0300 Line 4: Commit: Liron Aravot <[email protected]> Line 5: CommitDate: 2014-05-08 16:59:44 +0300 Line 6: Line 7: core: adding option to not connect host to inactive domains servers It seems that you adding an option to *connect* host to inactive domains servers (without the not) Line 8: Line 9: This patch adds support for connecting a host only the the storage Line 10: servers of unknown/active domains. Line 11: Line 5: CommitDate: 2014-05-08 16:59:44 +0300 Line 6: Line 7: core: adding option to not connect host to inactive domains servers Line 8: Line 9: This patch adds support for connecting a host only the the storage > s/only/only to/ 1) Also please remove the double "the" 2) I think that the patch adds support for connecting a host *also* to the storage servers (instead only) Line 10: servers of unknown/active domains. Line 11: Line 12: Change-Id: I7cdde23f8513afa119af6eeff0a02e77c43395f3 http://gerrit.ovirt.org/#/c/27522/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java: Line 34: statuses = Line 35: EnumSet.of(StorageDomainStatus.Active, StorageDomainStatus.InActive, StorageDomainStatus.Unknown); Line 36: } else { Line 37: statuses = EnumSet.of(StorageDomainStatus.Active, StorageDomainStatus.Unknown); Line 38: } I would consider to re-factor this to a separate method Line 39: Line 40: _connections = Line 41: DbFacade.getInstance() Line 42: .getStorageServerConnectionDao() http://gerrit.ovirt.org/#/c/27522/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java: Line 15: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; Line 16: Line 17: @InternalCommandAttribute Line 18: @NonTransactiveCommandAttribute Line 19: public class DisconnectHostFromStoragePoolServersCommand extends Why not using the new parameter class also here? Line 20: ConnectHostToStoragePoolServerCommandBase<HostStoragePoolParametersBase> { Line 21: Line 22: public DisconnectHostFromStoragePoolServersCommand(HostStoragePoolParametersBase parameters) { Line 23: super(parameters); Line 26: } Line 27: Line 28: @Override Line 29: protected void executeCommand() { Line 30: initConnectionList(true); Why not passing the parameter value Line 31: Line 32: for (Map.Entry<StorageType, List<StorageServerConnections>> connectionToType : getConnectionsTypeMap().entrySet()) { Line 33: disconnectStorageByType(connectionToType.getKey(), connectionToType.getValue()); Line 34: } -- To view, visit http://gerrit.ovirt.org/27522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cdde23f8513afa119af6eeff0a02e77c43395f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
