Maor Lipchuk has uploaded a new change for review. Change subject: core: Connect Storage Pool on iSCSI update ......................................................................
core: Connect Storage Pool on iSCSI update We should catch the exception when calling ConnectStorageServer since we should try to connect all the hosts, and if one of them fails we should keep try to connect all the other hosts. Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e Bug-Url: https://bugzilla.redhat.com/1094023 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/28214/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java index d058a90..37ed1fb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java @@ -14,6 +14,7 @@ import org.ovirt.engine.core.common.businessentities.StorageType; import org.ovirt.engine.core.common.businessentities.VDS; import org.ovirt.engine.core.common.businessentities.VDSStatus; +import org.ovirt.engine.core.common.errors.VdcBLLException; import org.ovirt.engine.core.common.vdscommands.StorageServerConnectionManagementVDSParameters; import org.ovirt.engine.core.common.vdscommands.VDSCommandType; import org.ovirt.engine.core.compat.Guid; @@ -44,10 +45,17 @@ tasks.add(new Callable<Void>() { @Override public Void call() throws Exception { - final List<StorageServerConnections> conns = ISCSIStorageHelper.updateIfaces(connections, host.getId()); - runVdsCommand(VDSCommandType.ConnectStorageServer, - new StorageServerConnectionManagementVDSParameters(host.getId(), Guid.Empty, StorageType.ISCSI, conns) - ); + try { + final List<StorageServerConnections> conns = ISCSIStorageHelper.updateIfaces(connections, host.getId()); + runVdsCommand(VDSCommandType.ConnectStorageServer, + new StorageServerConnectionManagementVDSParameters(host.getId(), Guid.Empty, StorageType.ISCSI, conns) + ); + } catch (VdcBLLException e) { + log.errorFormat("Could not connect Host {0} - {1} to Iscsi Storage Server. The exception is: {2}", + host.getName(), + host.getId(), + e); + } return null; } }); -- To view, visit http://gerrit.ovirt.org/28214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
