Maor Lipchuk has posted comments on this change.
Change subject: Initial refactoring for ReconstructMasterDomain
......................................................................
Patch Set 1: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 82: new TransactionMethod<Object>() {
Please use the formatter of rhevm for the code changed code (tab before "new
TransactionMethod<Object>" should not be deleted)
Line 95:
but if this is not the last master we are also performing
MarkPoolInReconstructModeVdsCommand, and now the order is changed.
Not sure if it has any consequences but since it is a refactor patch maybe its
better not to change the order of operations.
Line 103: .getResourceManager()
You can change to Backend.getInstance().getResourceManager().RunVdsCommand
with runVdsCommand
Line 107: .getValue(),
ReconstructMarkAction.ClearJobs));
Please add an empty line before comment.
Line 113: .getResourceManager()
You can change to Backend.getInstance().getResourceManager().RunVdsCommand
with runVdsCommand
Line 127: .getStoragePoolIsoMapDAO()
You can replace to DbFacade.getInstance().getStoragePoolIsoMapDAO() with
getStoragePoolIsoMapDAO()
Line 145: .RunVdsCommand(
You can change to Backend.getInstance().getResourceManager().RunVdsCommand
with runVdsCommand
--
To view, visit http://gerrit.ovirt.org/5329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79fdcf9870a003fc79e273a6fc89351e3dad5b5c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
