Lior Vernia has posted comments on this change. Change subject: webadmin: Network dialog- displays default MTU if 'has MTU' is unchecked ......................................................................
Patch Set 4: (1 comment) Another comment, and it might be important. http://gerrit.ovirt.org/#/c/28099/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 725: Line 726: private void updateMtu() { Line 727: getMtu().setIsChangable(getHasMtu().getEntity() && !getExport().getEntity()); Line 728: Line 729: if (getExport().getEntity() || getHasMtu().getEntity()) { Actually, why does hasMtu control the MTU value? I would expect the value to be initialized to DefaultMtu in the initialization of NewNetworkModel, and not to touch it anymore. And if you don't change the value of MTU according to hasMtu, then everything becomes much simpler again. Line 730: getMtu().setEntity(null); Line 731: } else { Line 732: getMtu().setEntity((Integer) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.DefaultMtu)); Line 733: } -- To view, visit http://gerrit.ovirt.org/28099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f813fd292b56407c97ae69c1580061bbc0eef04 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
