Alon Bar-Lev has posted comments on this change. Change subject: reports: Split of engine-setup-plugin ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28243/1/ovirt-engine-reports.spec.in File ovirt-engine-reports.spec.in: Line 130: %{_javadir}/%{name} Line 131: %endif Line 132: Line 133: %files setup Line 134: %dir %attr(-, %{engine_user}, %{engine_group}) %{_datadir}/ovirt-engine/setup/ovirt_engine_setup/reports/ why these attributes? also, you do not need to own directory if you do not select individual files. bellow is sufficient. Line 135: %{_datadir}/ovirt-engine/setup/ovirt_engine_setup/reports/ Line 136: %{_datadir}/ovirt-engine/setup/plugins/*/ovirt-engine-reports/ Line 137: Line 138: %changelog -- To view, visit http://gerrit.ovirt.org/28243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1849f9f06523d5926b7e8cf35399cedb5146c718 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
