Federico Simoncelli has posted comments on this change. Change subject: core: Run upgradeStoragePool on cluster compatibility change ......................................................................
Patch Set 14: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java Line 115: } I see your point but we have several other places where we have similar checks. I'd like to think more about the correct information to hold in the database to cover most of those checks. Let's introduce this change across all the files later on. Line 159: sdStatDao.update(domain); It's updated in vdsm in several occasions: with the UpgradeStoragePool command, when you start the spm (if the entire DC was in maintenance mode) and when you attach a new data domain. Saggi had a page here: http://www.ovirt.org/wiki/Features/StorageDomainLiveUpgrade .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpgradeStoragePoolVDSCommandParameters.java Line 9: @XmlAccessorType(XmlAccessType.NONE) Done -- To view, visit http://gerrit.ovirt.org/2441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85201624bbb2f8c41cf3b184b89a8e199ff50e99 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
