Sharad Mishra has posted comments on this change.
Change subject: Set correct storage id for snapshots
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Looks good, just two inline questions.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
Line 264: if (dbImage != null) {
Is it safe to leave storageId as null in case where dbImage is null?
Line 265:
diskImage.setstorage_ids(dbImage.getstorage_ids());
Is it possible to have dbImage.getstorage_ids() to return 'null'?
--
To view, visit http://gerrit.ovirt.org/5322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I579838d688e11fbef3beb96ddb876447fe36ab65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
