Daniel Erez has posted comments on this change. Change subject: webadmin: Render client-side sorting more robust ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28268/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java: Line 25: Line 26: @Override Line 27: public int compare(T a, T b) { Line 28: int res = sortAscending ? comparator.compare(a, b) : comparator.compare(b, a); Line 29: return res != 0 ? res : Integer.signum(positions.get(b) - positions.get(a)); Since the objects shouldn't be identical, I still think it would be nicer to compare hashcodes as in: http://gerrit.ovirt.org/#/c/28225/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/comparators/EntityComparator.java Line 30: } Line 31: Line 32: @Override Line 33: public boolean equals(Object obj) { -- To view, visit http://gerrit.ovirt.org/28268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd1ce7763e516ad109fdae5d584b183ee44117c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
