Alexander Wels has posted comments on this change. Change subject: webadmin: Render client-side sorting more robust ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28268/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java: Line 90: } Line 91: Line 92: insertionIndex.clear(); Line 93: SortedSet<T> sortedItems = new TreeSet<T>(comparator) { Line 94: private int counter = 0; What about allAll, clear(), removeAll()? What about the iterators? There are all kinds of things that can bring this out of sync. Are we really gaining anything at this point by using a SortedSet vs a List? Line 95: Line 96: @Override Line 97: public boolean add(T e) { Line 98: insertionIndex.put(e, counter++); // item will be placed following all existing "equal" items -- To view, visit http://gerrit.ovirt.org/28268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd1ce7763e516ad109fdae5d584b183ee44117c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
