Alexander Wels has posted comments on this change. Change subject: userportal: extended event sub tab loading ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/28035/1//COMMIT_MSG Commit Message: Line 6: Line 7: userportal: extended event sub tab loading Line 8: Line 9: - Fixed issue where the event list was not showing Line 10: the loading indicator when loadin data. > *loading Done Line 11: Line 12: Change-Id: I81495d93c0fb9a7989ff2147d6bfcbd8d769d6ff Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079937 http://gerrit.ovirt.org/#/c/28035/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java: Line 63: }); Line 64: getModel().getPropertyChangedEvent().addListener(new IEventListener() { Line 65: @Override Line 66: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 67: if (args instanceof PropertyChangedEventArgs) { > For PropertyChangedEvent, "args" will always be an instance of PropertyChan Well findbugs complains which we can surpress with the xml file, then coverity also complains. So I just did the check on the cast so neither one would complain. Line 68: PropertyChangedEventArgs pcArgs = (PropertyChangedEventArgs) args; Line 69: if (PropertyChangedEventArgs.Args.PROGRESS.toString().equals(pcArgs.propertyName)) { Line 70: clearData(); Line 71: } Line 65: @Override Line 66: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 67: if (args instanceof PropertyChangedEventArgs) { Line 68: PropertyChangedEventArgs pcArgs = (PropertyChangedEventArgs) args; Line 69: if (PropertyChangedEventArgs.Args.PROGRESS.toString().equals(pcArgs.propertyName)) { > I'm really wondering why is PropertyChangedEventArgs.Args.PROGRESS an enum Well the thought was, if we can make all these strings an enum then we can make the interface work on the enum instead of having a million strings all over the place. But I will change it to a constant string. Line 70: clearData(); Line 71: } Line 72: } Line 73: } -- To view, visit http://gerrit.ovirt.org/28035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81495d93c0fb9a7989ff2147d6bfcbd8d769d6ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
