Omer Frenkel has posted comments on this change.
Change subject: engine: Move Gluster host
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 126: if (sourceCluster.supportsGlusterService()) {
why doing that only if there is storage pool for the cluster?
in case there is no storage pool we don't want to do this?
Line 155: if
(getVdsGroup(getParameters().getClusterId()).supportsGlusterService()) {
same question, why storage pool is needed?
Line 184: boolean forceAction = false;
why assume stuff and wait for frontend implementation?
add force option to parameters and use it, it should be false by default,
and will have the same behaviour.
Line 201: setSucceeded(true);
this is not needed since the succeeded is set true anyway in the end of the
execute
Line 224: setSucceeded(true);
same here
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java
Line 70: }
well this is just a matter of style, but the above can be written also like
this:
return getGlusterBrickDao().getGlusterVolumeBricksByServerId(vdsId).size()
> 0
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
Line 58: AddEventNotificationEntry(EventNotificationEntity.Host,
AuditLogType.GLUSTER_HOST_ADD_FAILED);
not sure but i think should be added in db as well
--
To view, visit http://gerrit.ovirt.org/5285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24bd7d34c2312c34de63371912444c21b2896737
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
