Allon Mureinik has posted comments on this change.

Change subject: engine: Improve iSCSI Bond CDA validation
......................................................................


Patch Set 10:

(1 comment)

minor comment inline, other than that, looks good

http://gerrit.ovirt.org/#/c/26931/10/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/IscsiBondValidatorTest.java
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/IscsiBondValidatorTest.java:

Line 1: package org.ovirt.engine.core.bll.validator;
Line 2: 
Line 3: import static junit.framework.Assert.assertEquals;
please use org.junit.Assert
Line 4: 
Line 5: import static org.mockito.Matchers.any;
Line 6: import static org.mockito.Mockito.doReturn;
Line 7: 


-- 
To view, visit http://gerrit.ovirt.org/26931
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0ac7e6af6cb87b500740d679af2f13e63dbeb5
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to