Frank Kobzik has uploaded a new change for review.

Change subject: webadmin: Pools main tab columns sorting
......................................................................

webadmin: Pools main tab columns sorting

This patch adds sorting of fields in Pools main tab in webadmin.

Change-Id: I5ca199f769b23fe963d2b2bc087bfd9d63756818
Signed-off-by: Frantisek Kobzik <[email protected]>
Bug-Url: https://bugzilla.redhat.com/1104790
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
2 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/28375/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
index 0b79750..bfa048e 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
@@ -170,12 +170,17 @@
     @Override
     protected void syncSearch()
     {
-        SearchParameters tempVar = new SearchParameters(getSearchString(), 
SearchType.VmPools, isCaseSensitiveSearch());
+        SearchParameters tempVar = new 
SearchParameters(applySortOptions(getSearchString()), SearchType.VmPools, 
isCaseSensitiveSearch());
         tempVar.setMaxCount(getSearchPageSize());
         super.syncSearch(VdcQueryType.Search, tempVar);
     }
 
     @Override
+    public boolean supportsServerSideSorting() {
+        return true;
+    }
+
+    @Override
     public void search()
     {
         super.search();
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
index fa9bab0..767e21f 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
@@ -2,6 +2,7 @@
 
 import org.ovirt.engine.core.common.businessentities.VmPool;
 import org.ovirt.engine.core.common.businessentities.VmPoolType;
+import org.ovirt.engine.core.searchbackend.PoolConditionFieldAutoCompleter;
 import org.ovirt.engine.ui.common.idhandler.ElementIdHandler;
 import org.ovirt.engine.ui.common.uicommon.model.MainModelProvider;
 import org.ovirt.engine.ui.common.widget.table.column.EnumColumn;
@@ -40,6 +41,7 @@
                 return object.getName();
             }
         };
+        nameColumn.makeSortable(PoolConditionFieldAutoCompleter.NAME);
         getTable().addColumn(nameColumn, constants.namePool(), "150px"); 
//$NON-NLS-1$
 
         CommentColumn<VmPool> commentColumn = new CommentColumn<VmPool>();
@@ -51,6 +53,7 @@
                 return Integer.toString(object.getAssignedVmsCount());
             }
         };
+        
assignedColumn.makeSortable(PoolConditionFieldAutoCompleter.ASSIGNED_VM_COUNT);
         getTable().addColumn(assignedColumn, constants.assignVmsPool(), 
"150px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<VmPool> runningColumn = new 
TextColumnWithTooltip<VmPool>() {
@@ -59,6 +62,7 @@
                 return Integer.toString(object.getRunningVmsCount());
             }
         };
+        
runningColumn.makeSortable(PoolConditionFieldAutoCompleter.RUNNING_VM_COUNT);
         getTable().addColumn(runningColumn, constants.runningVmsPool(), 
"150px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<VmPool> typeColumn = new EnumColumn<VmPool, 
VmPoolType>() {
@@ -67,6 +71,7 @@
                 return object.getVmPoolType();
             }
         };
+        typeColumn.makeSortable(PoolConditionFieldAutoCompleter.TYPE);
         getTable().addColumn(typeColumn, constants.typePool(), "150px"); 
//$NON-NLS-1$
 
         TextColumnWithTooltip<VmPool> descColumn = new 
TextColumnWithTooltip<VmPool>() {
@@ -75,6 +80,7 @@
                 return object.getVmPoolDescription();
             }
         };
+        descColumn.makeSortable(PoolConditionFieldAutoCompleter.DESCRIPTION);
         getTable().addColumn(descColumn, constants.descriptionPool(), 
"300px"); //$NON-NLS-1$
 
         getTable().addActionButton(new 
WebAdminButtonDefinition<VmPool>(constants.newPool()) {


-- 
To view, visit http://gerrit.ovirt.org/28375
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ca199f769b23fe963d2b2bc087bfd9d63756818
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to