Eli Mesika has posted comments on this change. Change subject: core,restapi: removed separator inconsistency, removed duplicates. ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/28343/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java: Line 357: } Line 358: Line 359: @Test Line 360: public void testGetAllMultiDiskImageSearch() throws Exception { Line 361: SearchParameters searchParam = new SearchParameters("Disks : ", SearchType.Disk); better having the same method concatenating RETURN_TYPE_SEPARTOR to this This should be done all over this file and as Moti's commented Line 362: SearchQuery<SearchParameters> searchQuery = spySearchQuery(searchParam); Line 363: searchQuery.executeQueryCommand(); Line 364: assertTrue(diskImageResultList == searchQuery.getQueryReturnValue().getReturnValue()); Line 365: } http://gerrit.ovirt.org/#/c/28343/2/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java: Line 45: public class QueryHelper { Line 46: Line 47: public static final String CONSTRAINT_PARAMETER = "search"; Line 48: Line 49: //when changing please keep consistent with org.ovirt.engine.core.searchbackend.SearchObjects.SAFE_EXPRESSION_SEPARATOR > Both modules depends on the common project (once is dependent directly and +1 for Moti's suggestion Line 50: public static final String RETURN_TYPE_SEPARATOR = " : "; Line 51: Line 52: public static final String CURRENT_CONSTRAINT_PARAMETER = "current"; Line 53: -- To view, visit http://gerrit.ovirt.org/28343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c72e0527f084e1453da7f720a23fe84dd94db6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
