Federico Simoncelli has posted comments on this change. Change subject: core: spm local in DeactivateStorageDomainCommand ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28441/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 227: getStoragePool().getmaster_domain_version())); Line 228: } Line 229: freeLock(); Line 230: Line 231: VDS spm = null; My only intent was to make spm a local variable. I'll move this back to the top of the method (I'll move it here when it will be more obvious why). Line 232: if (getStoragePool().getspm_vds_id() != null) { Line 233: spm = getVdsDAO().get(getStoragePool().getspm_vds_id()); Line 234: } Line 235: -- To view, visit http://gerrit.ovirt.org/28441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48155e8bf5649f7485dfcb80df2d3eb18949c961 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
