Maor Lipchuk has posted comments on this change.
Change subject: core: Testing MaxBlockDiskSize validation
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
Line 265: parameters.setDiskInfo(createDiskImage(16384));
Would be helpful to use constant (By that you can simply write MAX_BLOCK_SIZE *
2 and it would be much more readable)
Line 361: private storage_domains mockStorageDomain(Guid storageId, int
availableSize, int usedSize) {
What availableSize and usedSize are used for?
--
To view, visit http://gerrit.ovirt.org/5406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6b068f6a4ebb58859162c1cd89c53f7775aa68
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
