Tal Nisan has posted comments on this change. Change subject: core: Changed attach storage cmd & params to support add without activate ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28275/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachStorageDomainToPoolParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachStorageDomainToPoolParameters.java: Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public class AttachStorageDomainToPoolParameters extends StorageDomainPoolParametersBase { Line 6: private boolean activate = true; > iirc we have an GWT serialization issue that requiers all those member init Correct, checkstyle was supposed to "catch" it but for some reason it didn't Line 7: Line 8: public AttachStorageDomainToPoolParameters() { Line 9: } Line 10: -- To view, visit http://gerrit.ovirt.org/28275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d96b95ba2ca6f63623f89433741c2509ec3c0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
