Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: refactor db credentials questions ......................................................................
Patch Set 3: (2 comments) Does it pass "make validations"? http://gerrit.ovirt.org/#/c/28261/3/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: Line 807: self._dbenvkeys['newDatabase'] Line 808: ] = self.isNewDatabase() Line 809: except: Line 810: self.logger.debug('database connection failed', exc_info=True) Line 811: please, 2 lines here http://gerrit.ovirt.org/#/c/28261/3/packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py File packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py: Line 163: 'user': Defaults.DEFAULT_DB_USER, Line 164: 'password': Defaults.DEFAULT_DB_PASSWORD, Line 165: 'database': Defaults.DEFAULT_DB_DATABASE, Line 166: } Line 167: please 2 lines here Line 168: @util.export Line 169: @util.codegen Line 170: @osetupattrsclass Line 171: class EngineDBEnv(object): -- To view, visit http://gerrit.ovirt.org/28261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1451e581a89b750ab34c09e34faeb77403909f00 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
