Karnan t c has uploaded a new change for review. Change subject: webadmin:Tasks with longer description overlaps date/time fixed ......................................................................
webadmin:Tasks with longer description overlaps date/time fixed Tasks having longer description overlaps with date/time column in tasks panel.The overlapping part of the text is now replaced with '...' with proper padding. Change-Id: I84795780163a8196825f66bde5f2394cbb82f871 Bug-Url: https://bugzilla.redhat.com/1023929 Signed-off-by: Karnan TC <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/28470/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java index 97a500b..a95b517 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java @@ -13,6 +13,8 @@ import org.ovirt.engine.ui.uicommonweb.models.events.TaskListModel; import org.ovirt.engine.ui.webadmin.widget.label.FullDateTimeLabel; +import com.google.gwt.dom.client.Style.TextOverflow; +import com.google.gwt.dom.client.Style.Unit; import com.google.gwt.dom.client.Style.VerticalAlign; import com.google.gwt.resources.client.ImageResource; import com.google.gwt.user.client.ui.HasVerticalAlignment; @@ -37,7 +39,10 @@ panel.setWidth("100%"); //$NON-NLS-1$ addItemToPanel(panel, new Image(getStatusImage(task.getStatus())), "25px"); //$NON-NLS-1$ - addTextBoxToPanel(panel, new TextBoxLabel(), task.getDescription(), ""); //$NON-NLS-1$ + TextBoxLabel descriptionTextBoxLabel = new TextBoxLabel(); + descriptionTextBoxLabel.getElement().getStyle().setPaddingRight(5, Unit.PX); + descriptionTextBoxLabel.getElement().getStyle().setTextOverflow(TextOverflow.ELLIPSIS); + addTextBoxToPanel(panel, descriptionTextBoxLabel, task.getDescription(), ""); //$NON-NLS-1$ addValueLabelToPanel(panel, new FullDateTimeLabel(), task.getStartTime(), "150px"); //$NON-NLS-1$ addTextBoxToPanel(panel, new TextBoxLabel(), task.getEndTime() == null ? "" : constants.untilEndTime(), "80px"); //$NON-NLS-1$ //$NON-NLS-2$ addValueLabelToPanel(panel, new FullDateTimeLabel(), task.getEndTime(), "150px"); //$NON-NLS-1$ @@ -94,7 +99,10 @@ panel.setWidth("100%"); //$NON-NLS-1$ addItemToPanel(panel, new Image(getStatusImage(step.getStatus())), "25px"); //$NON-NLS-1$ - addTextBoxToPanel(panel, new TextBoxLabel(), step.getDescription(), ""); //$NON-NLS-1$ + TextBoxLabel descriptionTextBoxLabel = new TextBoxLabel(); + descriptionTextBoxLabel.getElement().getStyle().setPaddingRight(5, Unit.PX); + descriptionTextBoxLabel.getElement().getStyle().setTextOverflow(TextOverflow.ELLIPSIS); + addTextBoxToPanel(panel, descriptionTextBoxLabel, step.getDescription(), ""); //$NON-NLS-1$ addValueLabelToPanel(panel, new FullDateTimeLabel(), step.getStartTime(), "150px"); //$NON-NLS-1$ addTextBoxToPanel(panel, new TextBoxLabel(), step.getEndTime() == null ? "" : constants.until(), "80px"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ addValueLabelToPanel(panel, new FullDateTimeLabel(), step.getEndTime(), "150px"); //$NON-NLS-1$ @@ -116,14 +124,14 @@ public void collapseAllTasks() { for (int i = 0; i < tree.getItemCount(); i++) { - collapseAllTasksHelper((TreeItem) tree.getItem(i)); + collapseAllTasksHelper(tree.getItem(i)); } } private void collapseAllTasksHelper(TreeItem item) { item.setState(false); for (int i = 0; i < item.getChildCount(); i++) { - collapseAllTasksHelper((TreeItem) item.getChild(i)); + collapseAllTasksHelper(item.getChild(i)); } } -- To view, visit http://gerrit.ovirt.org/28470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I84795780163a8196825f66bde5f2394cbb82f871 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
