Gilad Chaplik has posted comments on this change.

Change subject: core: support NUMA in oVirt Scheduler
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28467/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java:

Line 47:                 continue;
Line 48:             }
Line 49:             // In case one of VM's virtual NUMA nodes (vNode) is 
pinned to physical NUMA nodes (pNode),
Line 50:             // host will be excluded ('filter out') when:
Line 51:             // * memory tune is strict (vNode memory cannot be spread 
across several pNodes' memory)
will not wish to handle preferred and interleave for now (could be handled 
later)
Line 52:             // [and]
Line 53:             // * host support NUMA configuration
Line 54:             // * there isn't enough memory for pinned vNode in pNode
Line 55:             if (isVmNumaPinned(vmNumaNodes) && vm.getNumaTuneMode() == 
NumaTuneMode.STRICT


-- 
To view, visit http://gerrit.ovirt.org/28467
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b41e5ac9d633953dec7bfab5621ace8bb1b13cd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Chuan Liao <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Xiaolei Shi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to