Liron Ar has posted comments on this change.

Change subject: core: set volume description to reflect ovf store status
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/26932/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java:

Line 125:         // description.put(OvfInfoFileConstants.Domains, 
Arrays.asList(getParameters().getStorageDomainId()));
Line 126:         // if (size != null) {
Line 127:         // description.put(OvfInfoFileConstants.Size, size);
Line 128:         // }
Line 129:         // return buildJson(description);
note - the code here is temporary - once http://gerrit.ovirt.org/#/c/28493/ 
will be merged the commented code will be returned.
while it's not marged vdsm supports only one line descriptions/
Line 130:         StringBuilder stringBuilder = new StringBuilder();
Line 131:         stringBuilder.append(OvfInfoFileConstants.IsUpdated);
Line 132:         stringBuilder.append(":");
Line 133:         stringBuilder.append(isUpdated);


-- 
To view, visit http://gerrit.ovirt.org/26932
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09fc7ab550cd86e7843656ba92a5322165703a2d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to