Sandro Bonazzola has posted comments on this change. Change subject: set the storage backend according to the config file ......................................................................
Patch Set 5: Code-Review+1 (1 comment) minor comment inline http://gerrit.ovirt.org/#/c/28271/5/ovirt_hosted_engine_ha/broker/storage_broker.py File ovirt_hosted_engine_ha/broker/storage_broker.py: Line 25: Line 26: from ..env import constants Line 27: from ..lib import monotonic Line 28: from ..lib.exceptions import RequestError Line 29: from ..lib.storage_backends import FilesystemBackend, BlockBackend, VdsmBackend I would prefer one line per import, but I'm fine if you want to keep this as is. Line 30: from ..lib.storage_backends import StorageBackendTypes Line 31: Line 32: Line 33: class StorageBroker(object): -- To view, visit http://gerrit.ovirt.org/28271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cf19510ae52157e21e08215bc88953f1c1f937c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
