Liron Ar has posted comments on this change. Change subject: core: Introducing HttpImageTaskVDSCommand ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/26674/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java: Line 403: DB(5002), Line 404: UPLOAD_FAILURE(5003), Line 405: // The VDS does not exist in memory Line 406: RESOURCE_MANAGER_VDS_NOT_FOUND(5004), Line 407: RETRIEVE_FAILURE(5005), > add to VdsmErrors.properties I removed it as it's unneeded and even if it was needed, unrelated to this patch :) Line 408: IRS_IMAGE_STATUS_ILLEGAL(5006), Line 409: IRS_REPOSITORY_NOT_FOUND(5009), Line 410: MAC_POOL_INITIALIZATION_FAILED(5010), Line 411: MAC_POOL_NOT_INITIALIZED(5011), http://gerrit.ovirt.org/#/c/26674/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java: Line 162: Line 163: protected void throwVdsErrorException(String message, VdcBllErrors error) { Line 164: VDSErrorException outEx = new VDSErrorException(message); Line 165: VDSError tempVar = new VDSError(); Line 166: tempVar.setCode(error); > please rename var Done Line 167: tempVar.setMessage(message); Line 168: outEx.setVdsError(tempVar); Line 169: throw outEx; Line 170: } -- To view, visit http://gerrit.ovirt.org/26674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc9284e62f75cc4958909bcb03c9b4fa8e30d7d1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
