Daniel Erez has posted comments on this change. Change subject: core: encapsulate isLastMaster logic ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28445/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 184: getParameters().isInactive() ? StorageDomainStatus.Locked : StorageDomainStatus.PreparingForMaintenance); Line 185: Line 186: final StorageDomain newMaster = electNewMaster(); Line 187: final Guid newMasterId = newMaster != null ? newMaster.getId() : Guid.Empty; Line 188: final boolean _isLastMaster = proceedStorageDomainTreatmentByDomainType(newMaster, true); probably worth removing the '_' prefix in a following patch... Line 189: Line 190: if (_isLastMaster) { Line 191: executeInNewTransaction(new TransactionMethod<Object>() { Line 192: @Override -- To view, visit http://gerrit.ovirt.org/28445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbbf89d26c8c4e8f90e68bb89472bb4a6ee4518 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
