Martin Peřina has posted comments on this change. Change subject: kdump: Add kdump plugin ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28385/5/src/plugins/ovirt-host-deploy/core/offlinepackager.py File src/plugins/ovirt-host-deploy/core/offlinepackager.py: Line 80: name in ('redhat', 'centos') and Line 81: version.split('.')[0] == '6' Line 82: ) or ( Line 83: name == 'fedora' and Line 84: version >= '20' > :))) Sorry, I had to be blind :-( Line 85: ) Line 86: ): Line 87: pkgs = [ Line 88: { http://gerrit.ovirt.org/#/c/28385/5/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 175: @plugin.event( Line 176: stage=plugin.Stages.STAGE_MISC, Line 177: condition=lambda self: self.environment[odeploycons.KdumpEnv.ENABLE], Line 178: ) Line 179: def _reconfigure(self): > _misc? why _reconfigure? Done Line 180: with open(odeploycons.FileLocations.KDUMP_CONFIG_FILE, 'r') as f: Line 181: content = f.read().splitlines() Line 182: Line 183: new_content = self._update_kdump_conf( -- To view, visit http://gerrit.ovirt.org/28385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
