Martin Peřina has posted comments on this change. Change subject: core: Configure fence_kdump during host deploy ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/28386/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 572: InstallerMessages.Severity.WARNING, Line 573: "Kdump detection is not supported by host!" Line 574: ); Line 575: } Line 576: > you must split these into two... you so the mechanism wait for prompt. Done Line 577: _parser.cliEnvironmentSet( Line 578: KdumpEnv.ENABLE, Line 579: _vds.isPmKdumpDetection() && fenceKdumpSupported Line 580: ); http://gerrit.ovirt.org/#/c/28386/4/pom.xml File pom.xml: Line 69: <dozer.version>5.2.0</dozer.version> Line 70: <cxf.version>2.2.7</cxf.version> Line 71: <sshd-core.version>0.11.0</sshd-core.version> Line 72: <otopi.version>1.2.0</otopi.version> Line 73: <ovirt-host-deploy.version>1.2.2</ovirt-host-deploy.version> > it will be 1.3 I think, and probably as this enters so early we should add Done Line 74: <org.ovirt.engine.api.ovirt-engine-extensions-api.version>0.0.0-SNAPSHOT</org.ovirt.engine.api.ovirt-engine-extensions-api.version> Line 75: <slf4j.version>1.7.5</slf4j.version> Line 76: <gwt.version>2.5.1</gwt.version> Line 77: <findbugs.version>2.5.2</findbugs.version> -- To view, visit http://gerrit.ovirt.org/28386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc12188588a6a35b8f03d26a9ee5ea55898943df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
