Tomas Jelinek has posted comments on this change. Change subject: core: Enable balloon by default - Patch 2 of 2 ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/22107/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 369: .getReturnValue(); Line 370: } Line 371: }; Line 372: Frontend.getInstance().runQuery(VdcQueryType.OsRepository, new OsQueryParameters( Line 373: OsRepositoryVerb.GetBalloonSupportMap), callback); > are you asking generally how queries would look? this code seems to be pretty straightforward - all the OsRepository queries are like this - I'd say it is ok Line 374: } Line 375: Line 376: public static void initDiskHotpluggableInterfacesMap() { Line 377: AsyncQuery callback = new AsyncQuery(); http://gerrit.ovirt.org/#/c/22107/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1874: Line 1875: boolean isBalloonEnabled = AsyncDataProvider.isBalloonEnabled(osType, Line 1876: cluster.getcompatibility_version()); Line 1877: Line 1878: getMemoryBalloonDeviceEnabled().setEntity(isBalloonEnabled); this would break the instance types since the balloon is an instance type managed field. Instead of setting it directly here you need to: getMemoryBalloonDeviceEnabled().setIsChangable(isBalloonEnabled); if (!isBalloonEnabled) { getBehavior().deactivateInstanceTypeManager(); getMemoryBalloonDeviceEnabled().setEntity(isBalloonEnabled); getBehavior().activateInstanceTypeManager(); } Line 1879: } Line 1880: Line 1881: private void initFirstBootDevice() Line 1882: { -- To view, visit http://gerrit.ovirt.org/22107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7803e45f07539090e5527ebc81bbc6c31df4e120 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
