Roy Golan has posted comments on this change.
Change subject: core+ui: allow vm/template/pool/disk name to contain period
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
Line 204: } else if
(!ValidationUtils.containslegalCharactersOrDot(vmPoolName)) {
remove this check and the "containsLegalCharsOrDot" because this will fail
validation by the annotations you have put.
in fact all this block is redundant. needs testing though
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
Line 47: }
I know you just refactored the current code but the use of those methods to
throw canDoActions redundant and superfluous and need to get rid of it.
--
To view, visit http://gerrit.ovirt.org/5445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17dc34fa4ed63604473bd53a7debf2ab4f68df84
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
