Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Schedule db credentials customization ......................................................................
Patch Set 5: (1 comment) please try to avoid push and especially rebase if there are opened issue you do not understand. http://gerrit.ovirt.org/#/c/28317/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py: Line 82: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 83: name=oengcommcons.Stages.DB_CONNECTION_CUSTOMIZATION, Line 84: before=( Line 85: oengcommcons.Stages.DIALOG_TITLES_E_DATABASE, Line 86: oengcommcons.Stages.DB_OWNERS_CONNECTIONS_CUSTOMIZED, > Dropped the before=E as it's indeed within titles. Not sure what you mean b I guess you need two names so that you can fix this stage to be in the middle. I suggest symmetric approach so that these DB_OWNER_... will have start and end just like any other dialog title so that you determine the ordering within the titles module only. Line 87: ), Line 88: after=( Line 89: oengcommcons.Stages.DIALOG_TITLES_S_DATABASE, Line 90: ), -- To view, visit http://gerrit.ovirt.org/28317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4fb9a7c47f2563bbd5faf537144e818b1e0b7ed Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
