Vojtech Szocs has posted comments on this change. Change subject: userportal: List all templates according to user permissions. ......................................................................
Patch Set 1: Verified; Looks good to me, approved Looks good to me, but in AsyncDataProvider.GetAllVmTemplates method, 'params.setFiltered(true)' is not really necessary because Frontend.RunQuery will take care of updating this attribute automatically (all UserPortal queries are sent with isFiltered=true). Asaf, can I update the patch and merge it? -- To view, visit http://gerrit.ovirt.org/5440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id723a6ba65ad5b9f433d51e5885318b6ce6c29f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
