Antoni Segura Puimedon has posted comments on this change. Change subject: net_config: use vdscli and setupNetworks ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28595/1/src/plugins/ovirt-hosted-engine-setup/network/bridge.py File src/plugins/ovirt-hosted-engine-setup/network/bridge.py: Line 194: ), Line 195: ) Line 196: def _misc(self): Line 197: self.logger.info(_('Configuring the management bridge')) Line 198: conn = vdscli.connect() > don't you need to specify if SSL must be used for the connection? vdscli auto detects it. Line 199: net_info = netinfo.NetInfo(self._getVdsCapabilities(conn)) Line 200: bridge_port = self.environment[ohostedcons.NetworkEnv.BRIDGE_IF] Line 201: bridge = self.environment[ohostedcons.NetworkEnv.BRIDGE_NAME] Line 202: networks = {bridge: {}} -- To view, visit http://gerrit.ovirt.org/28595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
