Yevgeny Zaspitsky has uploaded a new change for review. Change subject: engine: Remove unused code from CommandBase. ......................................................................
engine: Remove unused code from CommandBase. Private methods getAsyncTask and internalGetTaskType aren't in use. Thus were removed. Change-Id: I5c85e76d53a1bcaa830815c212102bd8d198cd9e Signed-off-by: Yevgeny Zaspitsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 0 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/28630/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 8460faa..127b18f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -1634,13 +1634,6 @@ return TaskManagerUtil.concreteCreateTask(taskId, this, asyncTaskCreationInfo, parentCommand); } - private AsyncTasks getAsyncTask( - Guid taskId, - AsyncTaskCreationInfo asyncTaskCreationInfo, - VdcActionType parentCommand) { - return TaskManagerUtil.getAsyncTask(taskId, this, asyncTaskCreationInfo, parentCommand); - } - public VdcActionParametersBase getParentParameters(VdcActionType parentCommand) { VdcActionParametersBase parentParameters = getParametersForTask(parentCommand, getParameters()); if (parentParameters.getParametersCurrentUser() == null && getCurrentUser() != null) { @@ -1653,17 +1646,6 @@ AsyncTaskCreationInfo asyncTaskCreationInfo, VdcActionType parentCommand) { return TaskManagerUtil.createAsyncTask(this, asyncTaskCreationInfo, parentCommand); - } - - /** @return The type of task that should be created for this command. Commands that do not create async tasks should throw a {@link UnsupportedOperationException} */ - private AsyncTaskType internalGetTaskType() { - if (hasTaskHandlers()) { - if (getParameters().getExecutionReason() == CommandExecutionReason.REGULAR_FLOW) { - return getCurrentTaskHandler().getTaskType(); - } - return getCurrentTaskHandler().getRevertTaskType(); - } - return getTaskType(); } /** @return The type of task that should be created for this command. -- To view, visit http://gerrit.ovirt.org/28630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5c85e76d53a1bcaa830815c212102bd8d198cd9e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
