Juan Hernandez has posted comments on this change. Change subject: engine : volume profile export to pdf command ......................................................................
Patch Set 22: (4 comments) http://gerrit.ovirt.org/#/c/28000/22/backend/manager/dependencies/pom.xml File backend/manager/dependencies/pom.xml: Line 78: <dependency> Line 79: <groupId>com.itextpdf</groupId> Line 80: <artifactId>itextpdf</artifactId> Line 81: <version>${itextpdf.version}</version> Line 82: <scope>provided</scope> The "provided" scope isn't needed here. Line 83: </dependency> Line 84: Line 85: <dependency> Line 86: <groupId>org.ovirt.ovirt-host-deploy</groupId> http://gerrit.ovirt.org/#/c/28000/22/backend/manager/modules/common/pom.xml File backend/manager/modules/common/pom.xml: Line 55: <groupId>com.itextpdf</groupId> Line 56: <artifactId>itextpdf</artifactId> Line 57: <version>${itextpdf.version}</version> Line 58: <scope>provided</scope> Line 59: </dependency> Why is this needed? In theory it shouldn't be needed, as you aren't importing any itext class in the common module. Line 60: Line 61: </dependencies> Line 62: Line 63: <build> http://gerrit.ovirt.org/#/c/28000/22/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 222: Requires: openstack-java-resteasy-connector >= %{openstack_java_version} Line 223: Requires: postgresql-jdbc Line 224: Requires: quartz Line 225: Requires: snmp4j Line 226: Requires: itextpdf As far as I know there isn't any itextpdf package in Fedora. There is a itext-core package, but it contains a version much older than the one you are using. All in all I think you should remove this dependency. The build process will just get the itextpdf.jar from the maven repository and bundle it in the ovirt package. Line 227: Requires: spring-ldap Line 228: Requires: springframework-aop Line 229: Requires: springframework-beans Line 230: Requires: springframework-context Line 705: com/woorea/openstack/sdk/main/openstack-client.jar openstack-java-sdk/openstack-client.jar Line 706: com/woorea/openstack/sdk/main/quantum-client.jar openstack-java-sdk/quantum-client.jar Line 707: com/woorea/openstack/sdk/main/quantum-model.jar openstack-java-sdk/quantum-model.jar Line 708: com/woorea/openstack/sdk/main/resteasy-connector.jar openstack-java-sdk/resteasy-connector.jar Line 709: com/itextpdf/main/itextpdf.jar This will create a broken symlink, as there is no itextpdf.jar file in Fedora. Line 710: org/aopalliance/main/aopalliance.jar Line 711: org/apache/commons/compress/main/commons-compress.jar Line 712: org/apache/commons/configuration/main/commons-configuration.jar commons-configuration.jar Line 713: org/apache/commons/httpclient/main/commons-httpclient.jar -- To view, visit http://gerrit.ovirt.org/28000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I208a77456487a5f735948d6cf9fec54f004b6e89 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
