Yair Zaslavsky has posted comments on this change. Change subject: api: Fixing RSDL issue ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28628/1/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java: Line 70: Line 71: public static RSDL loadRsdl(ApplicationMode applicationMode) throws IOException { Line 72: String fileName = Line 73: applicationMode == ApplicationMode.GlusterOnly ? ("/" + RsdlIOManager.GLUSTER_RSDL_RESOURCE_NAME) Line 74: : ("/" + RsdlIOManager.RSDL_RESOURCE_NAME); > Why do we need to change this? Hi, As I explained before, we have only two RSDLs - one for gluster, and one virt/all modes. With the changes I introduced + the fix, you actually get the correct applicationMode- for example, virtOnly. if I don't change this, then for virtOnly you will get the GLUSTR_RSDL_RESOURCE_NAME. Line 75: InputStream rsdlAsStrem = null; Line 76: try { Line 77: rsdlAsStrem = RsdlIOManager.loadAsStream(fileName); Line 78: return JAXB.unmarshal(rsdlAsStrem, RSDL.class); -- To view, visit http://gerrit.ovirt.org/28628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03f836e0784ce3a1b86fd7fc410acf07f4d5c8e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
