Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fixing adding group ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28667/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java: Line 35: attributesToKeys.put("sn", Authz.PrincipalRecord.LAST_NAME); Line 36: attributesToKeys.put("$DEPARTMENT", Authz.PrincipalRecord.DEPARTMENT); Line 37: attributesToKeys.put("$TITLE", Authz.PrincipalRecord.TITLE); Line 38: attributesToKeys.put("cn", Authz.GroupRecord.NAME); Line 39: attributesToKeys.put("$CN", Authz.GroupRecord.NAME); shouldn't this be either? just set cn as $CN in these that cn==$CN Line 40: attributesToKeys.put("$PRINCIPAL_NAME", Authz.PrincipalRecord.NAME); Line 41: } Line 42: Line 43: public static ExtMap generateQueryMap(List<String> ids, ExtUUID queryEntity) { -- To view, visit http://gerrit.ovirt.org/28667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c72f913e2588e83b9970315de2c5f18184510bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
